Thread (26 messages) 26 messages, 5 authors, 2025-08-19

Re: [PATCH 5/6] can: esd_usb: Rework display of error messages

From: Stefan Mätje <stefan.maetje@esd.eu>
Date: 2025-08-18 12:21:26
Also in: linux-can

Am Donnerstag, dem 14.08.2025 um 14:45 +0200 schrieb Marc Kleine-Budde:
On 13.08.2025 10:12:03, Marc Kleine-Budde wrote:
quoted
On 11.08.2025 23:06:10, Stefan Mätje wrote:
quoted
- esd_usb_open(): Get rid of duplicate "couldn't start device: %d\n"
  message already printed from esd_usb_start().
- Added the printout of error codes together with the error messages
  in esd_usb_close() and some in esd_usb_probe(). The additional error
  codes should lead to a better understanding what is really going
  wrong.
- Fix duplicate printout of network device name when network device
  is registered. Add an unregister message for the network device
  as counterpart to the register message.
If you want to print errors, please use '"%pE", ERR_PTR(err)', that will
decode the error code into human readable form.
Sorry, I meant to say "%pe".
Thanks for that hint. I will rework all occurrences of '"...: %d\n", err'
with a version based on "ERR_PTR(err)" and send a V2.

Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help