Re: [PATCH v5 net-next 09/10] net-memcg: Pass struct sock to mem_cgroup_sk_under_memory_pressure().

On Tue, Aug 19, 2025 at 06:23:56PM -0700, Jakub Kicinski wrote:

On Fri, 15 Aug 2025 20:16:17 +0000 Kuniyuki Iwashima wrote:

quoted

We will store a flag in the lowest bit of sk->sk_memcg.

Then, we cannot pass the raw pointer to mem_cgroup_under_socket_pressure().

Let's pass struct sock to it and rename the function to match other
functions starting with mem_cgroup_sk_.

Note that the helper is moved to sock.h to use mem_cgroup_from_sk().

Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>

Hi Shakeel, looks like you acked every single patch here but this one.
Is this intentional? :)

Nopes, sorry I missed it somehow. Please add:

Acked-by: Shakeel Butt <shakeel.butt@linux.dev>