Thread (3 messages) 3 messages, 3 authors, 2025-09-01

Re: [PATCH net] net: dsa: ks8995: Fix some error handling path in ks8995_probe()

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-08-30 19:24:20
Also in: kernel-janitors, lkml

On Sat, Aug 30, 2025 at 07:13:59PM +0200, Christophe JAILLET wrote:
If an error occurs after calling gpiod_set_value_cansleep(..., 0), it must
be undone by a corresponding gpiod_set_value_cansleep(..., 1) call as
already done in the remove function.

In order to easily do the needed clean-up in the probe, add a new
devm_add_action_or_reset() call and simplify the remove function
accordingly.

Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Signed-off-by: Christophe JAILLET <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help