Thread (3 messages) 3 messages, 2 authors, 2025-09-01

Re: [PATCH v2 net-next] ipv6: annotate data-races around devconf->rpl_seg_enabled

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-08-30 02:27:39
Also in: lkml

On Wed, 27 Aug 2025 16:12:43 +0800 Yue Haibing wrote:
Also initializes extra1 and extra2 to SYSCTL_ZERO and SYSCTL_ONE
respectively to avoid negative value writes, which may lead to
unexpected results in ipv6_rpl_srh_rcv().
By unexpected results you mean that min() is intended to return 0
when either value is zero, but if one of the values is negative it
will in fact return non-zero?

That's a fair point, but I'm not sure whether we should be sending
that up as a fix. It's more of a sanity check that prevents
unintentional misconfiguration.. Please split this patch into two
separate ones, and send the minmax one without a Fixes tag.
Please include more of the explanation I have provided in the first
paragraph in the commit message, "unexpected results" is too vague
by itself.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help