Hi,

On Fri, 22 Aug 2025 20:09:16 +0530 Parvathi Pudi wrote:

quoted

+	struct net_device_stats *ndevstats;

quoted

+	ndevstats = &emac->ndev->stats;

Please don't use netdev stats, quoting the header:

struct net_device_stats	stats; /* not used by modern drivers */

Store the counters you need in driver's private struct and implement
.ndo_get_stats64

sure, we will verify and use the suggested approach.

quoted

+	if (!pkt_info->sv_frame) {

sv_frame seems to always be false at this stage?
Maybe delete this diff if that's the case, otherwise it feels like
the skb_free below should be accompanied by some stat increment.

Yes, We will remove this for now.

quoted

+		skb_put(skb, actual_pkt_len);
+
+		/* send packet up the stack */
+		skb->protocol = eth_type_trans(skb, ndev);
+		netif_receive_skb(skb);
+	} else {
+		dev_kfree_skb_any(skb);
+	}

The rest LGTM.

Thanks and Regards
Parvathi.