Hi Alexande，

-----Original Message-----
From: Alexander Stein <redacted>
Sent: 2025年8月27日 16:33
To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
festevam@gmail.com; richardcochran@gmail.com; andrew+netdev@lunn.ch;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; mcoquelin.stm32@gmail.com;
alexandre.torgue@foss.st.com; frieder.schrempf@kontron.de;
primoz.fiser@norik.com; othacehe@gnu.org;
Markus.Niebel@ew.tq-group.com; Joy Zou [off-list ref]
Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org;
linux@ew.tq-group.com; netdev@vger.kernel.org; linux-pm@vger.kernel.org;
linux-stm32@st-md-mailman.stormreply.com; Frank Li [off-list ref]
Subject: [EXT] Re: [PATCH v9 2/6] arm64: dts: freescale: rename imx93.dtsi to
imx91_93_common.dtsi and modify them

Caution: This is an external email. Please take care when clicking links or
opening attachments. When in doubt, report the message using the 'Report
this email' button


Hi,

Am Montag, 25. August 2025, 11:12:19 CEST schrieb Joy Zou:

quoted

The design of i.MX91 platform is very similar to i.MX93 and only
some small differences.

If the imx91.dtsi include the imx93.dtsi, each add to imx93.dtsi
requires an remove in imx91.dtsi for this unique to i.MX93, e.g. NPU.
The i.MX91 isn't the i.MX93 subset, if the imx93.dtsi include the
imx91.dtsi, the same problem will occur.

Common + delta is better than common - delta, so add

imx91_93_common.dtsi

quoted

for i.MX91 and i.MX93, then the imx93.dtsi and imx91.dtsi will include the
imx91_93_common.dtsi.

Rename imx93.dtsi to imx91_93_common.dtsi and move i.MX93 specific
part from imx91_93_common.dtsi to imx93.dtsi.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Joy Zou <redacted>
---
Changes for v7:
1.The aliases are removed from common.dtsi because the imx93.dtsi aliases
  are removed.

Changes for v6:
1. merge rename imx93.dtsi to imx91_93_common.dtsi and move i.MX93
   specific part from imx91_93_common.dtsi to imx93.dtsi patch.
2. restore copyright time and add modification time.
3. remove unused map0 label in imx91_93_common.dtsi.
---
 .../{imx93.dtsi => imx91_93_common.dtsi}      |  140 +-
 arch/arm64/boot/dts/freescale/imx93.dtsi      | 1484 ++---------------
 2 files changed, 163 insertions(+), 1461 deletions(-)
 copy arch/arm64/boot/dts/freescale/{imx93.dtsi =>

imx91_93_common.dtsi} (91%)

quoted

 rewrite arch/arm64/boot/dts/freescale/imx93.dtsi (97%)

It's not shown in the diff, but can you add a 'soc' phandle for 'soc@0' node?
So it can be referenced by imx91 or imx93 individually.

Add it when needed to reduce difference and facilitate review.
BR
Joy Zou

Best regards
Alexander