Re: [PATCH v3] ethernet: tlan: Convert to use jiffies macro
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2025-08-27 22:22:38
Also in:
lkml
On 8/27/2025 12:54 AM, zhang.enpei@zte.com.cn wrote:
From: Zhang Enpei <redacted> Use time_is_before_eq_jiffies macro instead of using jiffies directly to handle wraparound. Signed-off-by: Zhang Enpei <redacted> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
quoted hunk ↗ jump to hunk
drivers/net/ethernet/ti/tlan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index a55b0f951181..7c5e51284942 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c@@ -1817,7 +1817,6 @@ static void tlan_timer(struct timer_list *t) { struct tlan_priv *priv = timer_container_of(priv, t, timer); struct net_device *dev = priv->dev; - u32 elapsed; unsigned long flags = 0; priv->timer.function = NULL;@@ -1844,8 +1843,7 @@ static void tlan_timer(struct timer_list *t) case TLAN_TIMER_ACTIVITY: spin_lock_irqsave(&priv->lock, flags); if (priv->timer.function == NULL) { - elapsed = jiffies - priv->timer_set_at; - if (elapsed >= TLAN_TIMER_ACT_DELAY) { + if (time_is_before_eq_jiffies(priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) { tlan_dio_write8(dev->base_addr, TLAN_LED_REG, TLAN_LED_LINK); } else {
Attachments
- OpenPGP_signature.asc [application/pgp-signature] 236 bytes