Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC Transport
From: Adam Young <hidden>
Date: 2025-08-26 22:37:59
Also in:
lkml
From: Adam Young <hidden>
Date: 2025-08-26 22:37:59
Also in:
lkml
On 8/22/25 04:21, Jeremy Kerr wrote:
quoted
+static int mctp_pcc_ndo_open(struct net_device *ndev) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev = + netdev_priv(ndev); + struct mctp_pcc_mailbox *outbox = + &mctp_pcc_ndev->outbox; + struct mctp_pcc_mailbox *inbox = + &mctp_pcc_ndev->inbox;Minor: I don't think these need wrapping?
The outbox and inbox lines are longer than the mctp_pcc_ndev line, and they depend on it. This ordering and wrapping passes the xmas tree check and keeps assignment with declaration.