Re: [PATCH net v2] net: dlink: fix multicast stats being counted incorrectly

On Fri, Aug 22, 2025 at 09:02:46PM +0900, Yeounsu Moon wrote:

`McstFramesRcvdOk` counts the number of received multicast packets, and
it reports the value correctly.

However, reading `McstFramesRcvdOk` clears the register to zero. As a
result, the driver was reporting only the packets since the last read,
instead of the accumulated total.

Fix this by updating the multicast statistics accumulatively instaed of
instantaneously.

Fixes: 3401299a1b9e747cbf7de2cc0c8f6376c3cbe565 ("de6*/dl2k/sundance: Move the D-Link drivers")

The hash for fixes tends to be shorter than that.

Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")

If you add this to your .git/config

[pretty]
        fixes = Fixes: %h (\"%s\")

You can do

git log --pretty=fixes 3401299a1b9e747cbf7de2cc0c8f6376c3cbe565
Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")

This problem actually goes back further:

git blame 3401299a1b9e~1 drivers/net/dl2k.c

shows it was broken in the first commit in git.

So the correct Fixes: tag is:

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

    Andrew

---
pw-bot: cr