Thread (14 messages) 14 messages, 3 authors, 2025-08-21

Re: [PATCH net-next v13 4/5] net: ti: prueth: Adds link detection, RX and TX support.

From: Parvathi Pudi <parvathi@couthit.com>
Date: 2025-08-20 13:08:38
Also in: linux-arm-kernel, linux-devicetree, lkml

Hi,
On Mon, 18 Aug 2025 18:39:37 +0530 (IST) Parvathi Pudi wrote:
quoted
+       if (num_rx_packets < budget && napi_complete_done(napi, num_rx_packets))
                enable_irq(emac->rx_irq);
-       }
 
        return num_rx_packets;
 }

We will address this in the next version.
Ideally:

if (num_rx < budget && napi_complete_done()) {
	enable_irq();
	return num_rx;
}

	return budget;
However, if num_rx < budget and if napi_complete_done() is false, then
instead of returning the num_rx the above code will return budget.

So, unless I am missing something, the previous logic seems correct to me.
Please let me know otherwise.


Thanks and Regards,
Parvathi.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help