Re: [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets

From
Russell King (Oracle) <linux@armlinux.org.uk>
Date
2025-08-20 07:07:21
Also in
lkml
Reply to
Oleksij Rempel, 2025-08-18
On Mon, Aug 18, 2025 at 11:02:14AM +0200, Oleksij Rempel wrote:
Hi all,

this series reworks how stmmac handles receive checksum offload
(CoE) errors on dwmac4.

At present, when CoE is enabled, the hardware silently discards any
frame that fails checksum validation. These packets never reach the
driver and are not accounted in the generic drop statistics. They are
only visible in the stmmac-specific counters as "payload error" or
"header error" packets, which makes it harder to debug or monitor
network issues.
FYI, there are counters at 0x214 and 0x228 that indicate header
problems, including checksum failures. There are also counters
at 0x234, 0x23c, 0x244 that count udp, tcp and icmp checksum
errors.

So, the hardware does keep statistics. Maybe we should make use
of those rather than the approach in this series?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Thread (6 messages) 6 messages, 3 authors, last reply 2025-08-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help