Thread (5 messages) flat view 5 messages, 3 authors, 2025-08-18

Re: [PATCH] net: pcs-rzn1-miic: Correct MODCTRL register offset

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: 2025-08-18 16:24:11
Also in: linux-renesas-soc, lkml

Hi Wolfram,

Thank for the review.

On Mon, Aug 18, 2025 at 4:58 PM Wolfram Sang
[off-list ref] wrote:
On Mon, Aug 18, 2025 at 04:07:57PM +0100, Prabhakar wrote:
quoted
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC.
According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30)
[0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset
0x8, not 0x20 as previously defined.

[0] https://www.renesas.com/en/document/mah/rzn1d-group-rzn1s-group-rzn1l-group-users-manual-r-engine-and-ethernet-peripherals?r=1054571

Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Cc: stable@kernel.org
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I can also test it on my N1D board next week.
Perfect, I dont have access to the RZ/N1 board but I'm working on
reusing the same driver for a new SoC which has the same register.

Cheers,
Prabhakar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help