Thread (16 messages) 16 messages, 3 authors, 2025-08-19

Re: [PATCH net] virtio_net: adjust the execution order of function `virtnet_close` during freeze

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-08-18 15:39:18
Also in: lkml, virtualization

On Mon, 18 Aug 2025 09:15:22 +0800 Junnan Wu wrote:
quoted
quoted
Yes, you are right. The commit of this fix tag is the first commit I
found which add function `virtnet_poll_cleantx`. Actually, we are not
sure whether this issue appears after this commit.

In our side, this issue is found by chance in version 5.15.

It's hard to find the key commit which cause this issue
for reason that the reproduction of this scenario is too complex.  
I think the problem needs to be more clearly understood, and then it
will be easier to find the fixes tag. At the face of it the patch
makes it look like close() doesn't reliably stop the device, which
is highly odd.  
Yes, you are right. It is really strange that `close()` acts like
that, because current order has worked for long time. But panic call
stack in our env shows that the function `virtnet_close` and
`netif_device_detach` should have a correct execution order. And it
needs more time to find the fixes tag. I wonder that is it must have
fixes tag to merge?

By the way, you mentioned that "the problem need to be more clearly
understood", did you mean the descriptions and sequences in commit
message are not easy to understand? Do you have some suggestions
about this?
Perhaps Jason gets your explanation and will correct me, but to me it
seems like the fix is based on trial and error rather than clear
understanding of the problem. If you understood the problem clearly
you should be able to find the Fixes tag without a problem..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help