Re: [PATCH 1/6] dt-bindings: clock: mediatek: Add new MT8189 clock

On 18/08/2025 13:57, irving.ch.lin wrote:

From: Irving-ch Lin <redacted>

Add the new binding documentation for system clock
and functional clock on MediaTek MT8189.

Signed-off-by: Irving-ch Lin <redacted>

Never tested so just quick review to for obvious issues. I won't bother
with full review :(

+
+examples:
+  - |
+    imp_iic_wrap_ws_clk@11b21000 {

1. Follow closely DTS coding style.

2. Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


Best regards,
Krzysztof