Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760

Hi Kakub,

Thank you for reviewing the patches.

On 16/08/25 7:10 am, Jakub Kicinski wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Wed, 13 Aug 2025 16:03:55 +0530 Parthiban Veerasooran wrote:

quoted

+#define LAN865X_REG_FIXUP            0x00010077
+#define LAN865X_FIXUP_VALUE          0x0028

Looks like the application note explains what this register is and what
is the meaning of the bits in it. Please break this up and name
properly. "FIXUP_REGISTER" and "FIXUP_VALUE" is about as useful
as naming it "REGSITER_AT_10077" and "VALUE_28" :/

Yes, sure. I will update the correct details in the next version.

Since this falls under the initial settings, I initially kept this 
configuration as a "fixup," similar to what we did in the PHY driver. In 
that case, the PHY initial settings didn’t have valid register names or 
details, so the "fixup" approach was appropriate.

However, in this case, we do have the register names and details 
available in the configuration application note. So, I will update the 
configuration accordingly.

Best regards,
Parthiban V

--
pw-bot: cr