Re: [RFC net-next v3 7/7] net: devmem: allow binding on rx queues with same MA devices

On Fri, Aug 15, 2025 at 10:24:33AM -0700, Jakub Kicinski wrote:

On Fri, 15 Aug 2025 14:03:48 +0300 Dragos Tatulea wrote:

quoted

+		rxq_dma_dev = netdev_queue_get_dma_dev(netdev, rxq_idx);
+		/* Multi-PF netdev queues can belong to different DMA devoces.

Just saw the "devoces" typo. Will fix this too.

quoted

+		 * Block this case.
+		 */
+		if (rxq_dma_dev && dma_dev && rxq_dma_dev != dma_dev) {

Why rxq_dma_dev ? 🤔️
Don't we want to error out if the first queue gave us a DMA dev but the
second gave us a NULL ?

Hmm, yes... I didn't take this case into account. Will fix.

quoted

+			NL_SET_ERR_MSG(extack, "Can't bind to queues from different dma devices");

_FMT the conflicting queue IDs into this?

Sure. Will print the last dma_dev index and the current rxq_dma_dev index.

Thanks,
Dragos