[PATCH v3 04/11] rust: phy: replace `MaybeUninit::zeroed().assume_init()` with `pin_init::zeroed()`
From: Benno Lossin <lossin@kernel.org>
Date: 2025-08-14 09:31:19
Also in:
lkml, rust-for-linux
Subsystem:
ethernet phy library [rust], networking [general], rust, the rest · Maintainers:
FUJITA Tomonori, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Miguel Ojeda, Linus Torvalds
All types in `bindings` implement `Zeroable` if they can, so use `pin_init::zeroed` instead of relying on `unsafe` code. If this ends up not compiling in the future, something in bindgen or on the C side changed and is most likely incorrect. Signed-off-by: Benno Lossin <lossin@kernel.org> --- rust/kernel/net/phy.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs
index 7de5cc7a0eee..3e5565a6a130 100644
--- a/rust/kernel/net/phy.rs
+++ b/rust/kernel/net/phy.rs@@ -556,9 +556,7 @@ pub const fn create_phy_driver<T: Driver>() -> DriverVTable { } else { None }, - // SAFETY: The rest is zeroed out to initialize `struct phy_driver`, - // sets `Option<&F>` to be `None`. - ..unsafe { core::mem::MaybeUninit::<bindings::phy_driver>::zeroed().assume_init() } + ..pin_init::zeroed() })) }
--
2.50.1