On 17/05/2025 04:29, Jakub Kicinski wrote:

On Wed, 14 May 2025 15:04:28 +0300 Roger Quadros wrote:

quoted

The TRM doesn't mention anything about order of evaluation of the
classifier rules however it does mention in [1]
"if multiple classifier matches occur, the highest match
with thread enable bit set will be used."

So we're not sure how to maintain the user requested ordering?

Currently we are using the user/ethtool provided location as is.

Am I reading this correctly? If so then ..

quoted

+	if (fs->location == RX_CLS_LOC_ANY ||

.. why are we rejecting LOC_ANY? 

Because driver doesn't have logic to decide the location and relies on ethtool to
decide it if user doesn't supply it.

I'd think that, in fact, LOC_ANY should be the only loc we can support.
Note that ethtool hides the location logic on the CLI, if user doesn't
request a location and driver reports RX_CLS_LOC_SPECIAL ethtool will
set the location to LOC_ANY.

quoted

+	    fs->location >= port->rxnfc_max)
+		return -EINVAL;

-- 
cheers,
-roger