Thread (7 messages) flat view 7 messages, 4 authors, 2025-08-12

Re: [PATCH 1/3] tcp: cdg: remove redundant __GFP_NOWARN

From: Eric Dumazet <edumazet@google.com>
Date: 2025-08-11 08:54:18
Also in: lkml

On Sun, Aug 10, 2025 at 12:30 AM Qianfeng Rong [off-list ref] wrote:
quoted hunk ↗ jump to hunk
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
__GFP_NOWARN.

Signed-off-by: Qianfeng Rong <redacted>
---
 net/ipv4/tcp_cdg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_cdg.c b/net/ipv4/tcp_cdg.c
index ba4d98e510e0..fbad6c35dee9 100644
--- a/net/ipv4/tcp_cdg.c
+++ b/net/ipv4/tcp_cdg.c
@@ -379,7 +379,7 @@ static void tcp_cdg_init(struct sock *sk)
        /* We silently fall back to window = 1 if allocation fails. */
        if (window > 1)
                ca->gradients = kcalloc(window, sizeof(ca->gradients[0]),
-                                       GFP_NOWAIT | __GFP_NOWARN);
+                                       GFP_NOWAIT);
Reviewed-by: Eric Dumazet <edumazet@google.com>

It is unclear why GFP_NOWAIT was used here, while all other TCP
allocations use GFP_ATOMIC or GFP_KERNEL.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help