Re: [PATCH net] l2tp: do not use sock_hold() in pppol2tp_session_get_sock()

From
patchwork-bot+netdevbpf@kernel.org
Date
2025-08-28 00:30:04
Reply to
Eric Dumazet, 2025-08-26
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Tue, 26 Aug 2025 13:44:35 +0000 you wrote:
pppol2tp_session_get_sock() is using RCU, it must be ready
for sk_refcnt being zero.

Commit ee40fb2e1eb5 ("l2tp: protect sock pointer of
struct pppol2tp_session with RCU") was correct because it
had a call_rcu(..., pppol2tp_put_sk) which was later removed in blamed commit.

[...]
Here is the summary with links:
  - [net] l2tp: do not use sock_hold() in pppol2tp_session_get_sock()
    https://git.kernel.org/netdev/net/c/9b8c88f875c0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Thread (3 messages) 3 messages, 3 authors, last reply 2025-08-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help