Re: [PATCH v2 net 1/3] net: rose: split remove and free operations in rose_remove_neigh()
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2025-08-27 06:22:02
Also in:
linux-hams
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2025-08-27 06:22:02
Also in:
linux-hams
On Sat, Aug 23, 2025 at 2:00 AM Takamitsu Iwai [off-list ref] wrote:
The current rose_remove_neigh() performs two distinct operations: 1. Removes rose_neigh from rose_neigh_list 2. Frees the rose_neigh structure Split these operations into separate functions to improve maintainability and prepare for upcoming refcount_t conversion. The timer cleanup remains in rose_remove_neigh() because free operations can be called from timer itself. This patch introduce rose_neigh_put() to handle the freeing of rose_neigh structures and modify rose_remove_neigh() to handle removal only. Signed-off-by: Takamitsu Iwai <redacted>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>