Re: [PATCH net-next] net: phy: fixed: let fixed_phy_add always use addr 0 and remove return value
From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-08-27 00:40:10
Also in:
linux-m68k, linux-mips
From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-08-27 00:40:10
Also in:
linux-m68k, linux-mips
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski [off-list ref]: On Fri, 22 Aug 2025 22:36:11 +0200 you wrote:
We have only two users of fixed_phy_add(), both use address 0 and ignore the return value. So simplify fixed_phy_add() accordingly. Whilst at it, constify the fixed_phy_status configs. Note: fixed_phy_add() is a legacy function which shouldn't be used in new code, as it's use may be problematic: - No check whether a fixed phy exists already at the given address - If fixed_phy_register() is called afterwards by any other driver, then it will also use phy_addr 0, because fixed_phy_add() ignores the ida which manages address assignment Drivers using a fixed phy created by fixed_phy_add() in platform code, should dynamically create a fixed phy with fixed_phy_register() instead. [...]
Here is the summary with links:
- [net-next] net: phy: fixed: let fixed_phy_add always use addr 0 and remove return value
https://git.kernel.org/netdev/net-next/c/39e94fdce45f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html