Re: [PATCH net-next v2 01/15] net: define IPPROTO_QUIC and SOL_QUIC constants

Hi Namjae,

quoted

quoted

diff --git a/include/linux/socket.h b/include/linux/socket.h
index 3b262487ec06..a7c05b064583 100644
--- a/include/linux/socket.h
+++ b/include/linux/socket.h

@@ -386,6 +386,7 @@ struct ucred {
   #define SOL_MCTP    285
   #define SOL_SMC             286
   #define SOL_VSOCK   287
+#define SOL_QUIC     288

   /* IPX options */
   #define IPX_TYPE    1

diff --git a/include/uapi/linux/in.h b/include/uapi/linux/in.h
index ced0fc3c3aa5..34becd90d3a6 100644
--- a/include/uapi/linux/in.h
+++ b/include/uapi/linux/in.h

@@ -85,6 +85,8 @@ enum {
   #define IPPROTO_RAW         IPPROTO_RAW
     IPPROTO_SMC = 256,                /* Shared Memory Communications         */
   #define IPPROTO_SMC         IPPROTO_SMC
+  IPPROTO_QUIC = 261,                /* A UDP-Based Multiplexed and Secure Transport */
+#define IPPROTO_QUIC         IPPROTO_QUIC
     IPPROTO_MPTCP = 262,              /* Multipath TCP connection             */
   #define IPPROTO_MPTCP               IPPROTO_MPTCP
     IPPROTO_MAX

Can these constants be accepted, soon?

Samba 4.23.0 to be released early September will ship userspace code to
use them. It would be good to have them correct when kernel's start to
support this...

I'd like to test ksmbd with smbclient of samba, which includes quic support.
Which Samba branch should I use? How do I enable quic in Samba?
Do I need to update smb.conf?

With master or 4.23 the simplest way would be

smbclient //ksmbd-server/share \
   -Uuser%Passw0rd \
   --option='client smb transports = quic' \
   --option='tls verify peer = no_check' \
   -I 10.0.0.1

Note it only works with a name in the unc otherwise
quic can't work.

For development you may want to use
SSLKEYLOGFILE=/dev/shm/sslkeylogfile.txt smbclient ...

And point wireshark to /dev/shm/sslkeylogfile.txt with

wireshark -o tls.keylog_file:/dev/shm/sslkeylogfile.txt

Or you merge it into a pcapng file like this:

editcap --inject-secrets tls,/dev/shm/sslkeylogfile.txt capture.pcap.gz capture.pcapng.gz

Then 'wireshark capture.pcapng.gz' will have everything to decrypt.

metze