Thread (36 messages) flat view 36 messages, 3 authors, 2025-08-18

Re: [PATCH net-next v6 09/19] net: psp: update the TCP MSS to reflect PSP packet overhead

From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-08-14 13:58:27

On 8/12/25 2:29 AM, Daniel Zahka wrote:
quoted hunk ↗ jump to hunk
@@ -236,6 +237,10 @@ int psp_sock_assoc_set_tx(struct sock *sk, struct psp_dev *psd,
 	tcp_write_collapse_fence(sk);
 	pas->upgrade_seq = tcp_sk(sk)->rcv_nxt;
 
+	icsk = inet_csk(sk);
+	icsk->icsk_ext_hdr_len += psp_sk_overhead(sk);
I'm likely lost, but AFAICS the user-space can successfully call
multiple times psp_sock_assoc_set_tx() on the same socket, increasing
icsk->icsk_ext_hdr_len in an unbounded way.

/P
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help