Thread (9 messages) 9 messages, 4 authors, 2025-08-15

Re: [PATCH net-next 1/2] bridge: Redirect to backup port when port is administratively down

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-08-14 00:20:18
Also in: bridge

On Tue, 12 Aug 2025 11:02:12 +0300 Ido Schimmel wrote:
 	/* redirect to backup link if the destination port is down */
-	if (rcu_access_pointer(to->backup_port) && !netif_carrier_ok(to->dev)) {
+	if (rcu_access_pointer(to->backup_port) &&
+	    (!netif_carrier_ok(to->dev) || !netif_running(to->dev))) {
Not really blocking this patch, but I always wondered why we allow
devices with carrier on in admin down state. Is his just something we
have because updating 200 drivers which don't manage carrier today
would be a PITA? Or there's a stronger reason to allow this?
Hopefully I'm not misreading the patch..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help