Re: [PATCH net v2 1/2] devlink: let driver opt out of automatic phys_port_name generation

On 8/8/2025 11:53 AM, Jakub Kicinski wrote:

On Tue,  5 Aug 2025 15:33:41 -0700 Tony Nguyen wrote:

quoted

+	if (devlink_port->attrs.no_phys_port_name)
+		return 0;

Why are you returning 0 rather than -EOPNOTSUPP?
Driver which doesn't implement phys_port_name would normally return
-EOPNOTSUPP when user tries to read the sysfs file.

Jedrek is out so I'm not sure the reason, but it does seem
-EOPNOTSUPP would be more appropriate so I'll make that change.

Thanks,
Tony