Re: [RFC net-next 16/17] net/dibs: Move data path to dibs layer

From
Alexandra Winter <wintera@linux.ibm.com>
Date
2025-08-08 18:38:40
Also in
linux-rdma, linux-s390
Reply to
Simon Horman, 2025-08-07

On 07.08.25 22:34, Simon Horman wrote:
On Wed, Aug 06, 2025 at 05:41:21PM +0200, Alexandra Winter wrote:

...
quoted
diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
...
quoted
@@ -33,18 +32,18 @@ static void smcd_register_dev(struct dibs_dev *dibs);
 static void smcd_unregister_dev(struct dibs_dev *dibs);
 #if IS_ENABLED(CONFIG_ISM)
 static void smcd_handle_event(struct ism_dev *ism, struct ism_event *event);
-static void smcd_handle_irq(struct ism_dev *ism, unsigned int dmbno,
+static void smcd_handle_irq(struct dibs_dev *dibs, unsigned int dmbno,
 			    u16 dmbemask);
Hi Alexandria,

smcd_handle_irq is only declared (and defined) if CONFIG_ISM is enabled.
quoted
 
 static struct ism_client smc_ism_client = {
 	.name = "SMC-D",
 	.handle_event = smcd_handle_event,
-	.handle_irq = smcd_handle_irq,
 };
 #endif
 static struct dibs_client_ops smc_client_ops = {
 	.add_dev = smcd_register_dev,
 	.del_dev = smcd_unregister_dev,
+	.handle_irq = smcd_handle_irq,
But here smcd_handle_irq is used regardless of if CONFIG_ISM is enabled.

I believe this is addressed by the following patch in this series.
However, this does result ina transient build failure.
And they should be avoided as they break bisection.
quoted
 };
 
 static struct dibs_client smc_dibs_client = {
...
Fixed in next version.
I'll make sure, all patches build without ISM.
Thank you Simon.
Thread (48 messages) 48 messages, 4 authors, last reply 2025-09-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help