On 7/24/25 3:52 PM, Simon Horman wrote:

On Thu, Jul 24, 2025 at 09:30:19AM +0200, Jimmy Assarsson wrote:

...

quoted

diff --git a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
index 8145d25943de..4e4550115368 100644
--- a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
+++ b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c

@@ -4,7 +4,33 @@
   * Copyright (C) 2025 KVASER AB, Sweden. All rights reserved.
   */
  
+#include "kvaser_pciefd.h"
+
  #include <net/devlink.h>

Hi Jimmy,

Please consider squashing the two-line change above into
the previous patch in this series to avoid the following
transient Sparse warning.

   .../kvaser_pciefd_devlink.c:9:26: warning: symbol 'kvaser_pciefd_devlink_ops' was not declared. Should it be static?

Thanks!

Hi Simon!

Sure, I'll fix it in v4.
Thanks for reviewing!

Best regards,
jimmy