Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104
From: Vincent Mailhol <hidden>
Date: 2025-07-20 04:51:01
Also in:
linux-can
On 20/07/2025 at 09:02, Randy Dunlap wrote:
quoted hunk ↗ jump to hunk
Add a dependency on PC104 to limit (restrict) this driver kconfig prompt to kernel configs that have PC104 set. Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards") Signed-off-by: Randy Dunlap <redacted> Cc: Andre B. Oliveira <redacted> Cc: linux-can@vger.kernel.org Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: Vincent Mailhol <redacted> Cc: Andrew Lunn <andrew+netdev@lunn.ch> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- drivers/net/can/sja1000/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)--- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig +++ linux-next-20250718/drivers/net/can/sja1000/Kconfig@@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM config CAN_TSCAN1 tristate "TS-CAN1 PC104 boards" - depends on ISA + depends on ISA && PC104
A bit unrelated but ISA depends on X86_32 so I would suggest to add a COMPILE_TEST so that people can still do test builds on x86_64. depends on (ISA && PC104) || COMPILE_TEST Yours sincerely, Vincent Mailhol