Thread (14 messages) 14 messages, 5 authors, 2025-07-25

Re: [PATCH] usbnet: Set duplex status to unknown in the absence of MII

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-07-22 13:06:47
Also in: linux-usb

On Tue, Jul 22, 2025 at 10:09:33AM +0800, yicongsrfy@163.com wrote:
Thanks for your reply!

According to the "Universal Serial Bus Class Definitions for Communications Devices v1.2":
In Section 6.3, which describes notifications such as NetworkConnection and ConnectionSpeedChange,
there is no mention of duplex status.In particular, for ConnectionSpeedChange, its data payload
only contains two 32-bit unsigned integers, corresponding to the uplink and downlink speeds.
Thanks for checking this.

Just one more question. This is kind of flipping the question on its
head. Does the standard say devices are actually allowed to support
1/2 duplex? Does it say they are not allowed to support 1/2 duplex?

If duplex is not reported, maybe it is because 1/2 duplex is simply
not allowed, so there is no need to report it.
Since CDC has no way to obtain the duplex status of the device, ethtool displays a default
value of "Half". I think it would be better to display "unknown" instead of potentially showing
incorrect information — for example, my device is actually operating at 1Gbps Full-duplex,
but ethtool shows 1Gbps Half-duplex.
I agree that reporting 1/2 is probably wrong. But we have to decide
between "unknown" and "full".

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help