Re: [PATCH] sfc: handle NULL returned by xdp_convert_buff_to_frame()
From: Edward Cree <ecree.xilinx@gmail.com>
Date: 2025-07-28 14:28:28
Also in:
bpf
On 25/07/2025 13:38, Kunwu Chan wrote:
Proposed refinement:
...
if (net_ratelimit()) netif_err(efx, rx_err, efx->net_dev, - "XDP TX failed (%d)\n", err); + "XDP TX failed (%d)%s\n", err, + err == -ENOBUFS ? " [frame conversion]" : "");
Unnecessary, since efx_xdp_tx_buffers() never returns ENOBUFS.
channel->n_rx_xdp_bad_drops++; - trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); + if (err != -ENOBUFS) + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act);
Why prevent the tracepoint in this case??