Thread (39 messages) 39 messages, 4 authors, 2025-08-22

Re: [PATCH net-next v10 10/15] net: phy: marvell10g: Support SFP through phy_port

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-07-26 21:17:21
Also in: linux-arm-kernel, linux-arm-msm, linux-devicetree, lkml

+	} else if (port->not_described) {
+		/* This PHY can do combo-ports, i.e. 2 MDI outputs, usually one
+		 * of them going to an SFP and the other one to a RJ45
+		 * connector. If we don't have any representation for the port
+		 * in DT, and we are dealing with a non-SFP port, then we
+		 * mask the port's capabilities to report BaseT-only modes
+		 */
+		port->mediums = BIT(ETHTOOL_LINK_MEDIUM_BASET);
+
+		phy_port_filter_supported(port);
That seems a little bit error prone. Maybe add a helper to set
port->mediums, which also makes the phy_port_filter_supported() call?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help