Re: [PATCH net-next v3 3/5] netconsole: add support for strings with new line in netpoll_parse_ip_addr
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-07-25 20:42:25
Also in:
lkml
On Wed, 23 Jul 2025 10:20:31 -0700 Breno Leitao wrote:
quoted hunk ↗ jump to hunk
const char *end; + int len; - if (!strchr(str, ':') && - in4_pton(str, -1, (void *)addr, -1, &end) > 0) { - if (!*end) - return 0; - } - if (in6_pton(str, -1, addr->in6.s6_addr, -1, &end) > 0) { -#if IS_ENABLED(CONFIG_IPV6) - if (!*end) - return 1; -#else + len = strlen(str); + if (!len) return -1; -#endif - } + + if (str[len - 1] == '\n') + len -= 1; + + if (in4_pton(str, len, (void *)addr, -1, &end) > 0) + return 0; + if (IS_ENABLED(CONFIG_IPV6) && + in6_pton(str, len, addr->in6.s6_addr, -1, &end) > 0) + return 1; return -1;
Looks like we're removing the validation for reaching the end of the buffer? This should at least be explained in the commit message. AFAICT for IPv4 for example 1.2.3.4:xyz would have been rejected, now it's accepted. Personally I find the if (*end && *end != '\n') removed by subsequent patch cleaner than modifying the input string. I'll apply the first patch of the series..