Re: [PATCH net v2] et131x: Add missing check after DMA map

From
mark.einon@gmail.com
Date
2025-07-16 11:19:52
Also in
lkml
Reply to
Thomas Fourier, 2025-07-16
On Wed, 2025-07-16 at 11:47 +0200, Thomas Fourier wrote:
The DMA map functions can fail and should be tested for errors.
If the mapping fails, unmap and return an error.

Fixes: 38df6492eb51 ("et131x: Add PCIe gigabit ethernet driver et131x
to drivers/net")
Signed-off-by: Thomas Fourier <redacted>
---
v1 -> v2:
  - Fix subject
  - Fix double decrement of frag
  - Make comment more explicit about why there are two loops
Thanks for the updates Thomas, LGTM (also CC'd Simon who provided the
initial comments).

Acked-by: Mark Einon <mark.einon@gmail.com>
Thread (4 messages) 4 messages, 4 authors, last reply 2025-07-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help