Internal review discovered an error

On 7/10/25 15:12, admiyo@os.amperecomputing.com wrote:

+	if (pchan->chan.rx_alloc)
+		ret = pcc_write_to_buffer(chan, data);

This is the wrong check. The rx_alloc is expected to be used  for the 
type4, and the will be called from the type 3.

Going to add an explicit flag instead.

+	pcc_hdr = pchan->chan.shmem;
+	if (ioread32(&pcc_hdr->flags) & PCC_CMD_COMPLETION_NOTIFY)
+		pchan->chan.irq_ack = true;

This flag can be removed and replaced  with a check of the value in the 
original buffer, which is held in chan->current_req.


Updated version of the patch series to follow.