Thread (27 messages) 27 messages, 7 authors, 2025-07-14

Re: [PATCH v3 0/4] Enable ethernet on qcs615

From: Yijie Yang <hidden>
Date: 2025-07-14 02:28:09
Also in: linux-arm-kernel, linux-arm-msm, linux-devicetree, lkml


On 2025-01-21 15:54, Yijie Yang wrote:
Correct the definition and usage of phy-mode in both the DT binding and
driver code.
Add dts nodes and EMAC driver data to enable ethernet interface on
qcs615-ride platform.
The EMAC version currently in use on this platform is the same as that in
qcs404. The EPHY model is Micrel KSZ9031.

Signed-off-by: Yijie Yang <redacted>
---
Changes in v3:
- Correct the definition of 'rgmii' in ethernet-controller.yaml.
- Remove the redundant max-speed limit in the dts file.
- Update the definition of 'rgmii' to prevent any further misunderstandings.
- Update the phy-mode in the dts file from rgmii to rgmii-id.
- Mask the PHY mode passed to the driver to allow the MAC to add the delay.
- Update the low power mode exit interrupt from 662 to 661.
- Update the compatible string to fallback to qcs404 since they share the same hardware.
- Update base commit to next-20250120.
- Link to v2: https://lore.kernel.org/r/20241118-dts_qcs615-v2-0-e62b924a3cbd@quicinc.com (local)

---
Yijie Yang (4):
       dt-bindings: net: ethernet-controller: Correct the definition of phy-mode
       net: stmmac: dwmac-qcom-ethqos: Mask PHY mode if configured with rgmii-id
       arm64: dts: qcom: qcs615: add ethernet node
       arm64: dts: qcom: qcs615-ride: Enable ethernet node

  .../bindings/net/ethernet-controller.yaml          |   2 +-
  arch/arm64/boot/dts/qcom/qcs615-ride.dts           | 104 +++++++++++++++++++++
  arch/arm64/boot/dts/qcom/qcs615.dtsi               |  34 +++++++
  .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    |  18 +++-
  4 files changed, 152 insertions(+), 6 deletions(-)
---
base-commit: 9424d9acada6461344c71ac02f2f3fbcdd775498
change-id: 20241224-dts_qcs615-9612efea02cb
prerequisite-message-id: [ref]
prerequisite-patch-id: b97f36116c87036abe66e061db82588eb1bbaa9a

Best regards,

Since my last submission, I’ve been working on an updated version of the 
patch that incorporates the feedback received and improves the overall 
implementation. I plan to submit the revised version shortly.

Please let me know if there are any additional concerns or changes in 
direction I should be aware of. I’d really appreciate any guidance to 
ensure the patch aligns well with the current goals of the subsystem.


-- 
Best Regards,
Yijie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help