Re: [PATCH v3 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC

On 7/11/25 12:55 AM, Rob Herring wrote:

On Thu, Jul 10, 2025 at 08:28:15PM +0800, Luo Jie wrote:

quoted

NSS clock controller provides the clocks and resets to the networking
blocks such as PPE (Packet Process Engine) and UNIPHY (PCS) on IPQ5424
devices.

Add the compatible "qcom,ipq5424-nsscc" support based on the current
IPQ9574 NSS clock controller DT binding file. ICC clocks are always
provided by the NSS clock controller of IPQ9574 and IPQ5424, so add
interconnect-cells as required DT property.

Also add master/slave ids for IPQ5424 networking interfaces, which is
used by nss-ipq5424 driver for providing interconnect services using
icc-clk framework.

Signed-off-by: Luo Jie <redacted>
---

[...]

quoted

   clocks:
     items:

@@ -57,6 +61,7 @@ required:
   - compatible
   - clocks
   - clock-names
+  - '#interconnect-cells'

You just made this required for everyone. Again, that's an ABI change.

In this case it's actually valid, but should be a separate fixup change

Konrad