Thread (49 messages) read the whole thread 49 messages, 4 authors, 2025-07-28

Re: [PATCH net-next v9 4/8] netmem: use netmem_desc instead of page to access ->pp in __netmem_get_pp()

From: Mina Almasry <hidden>
Date: 2025-07-10 18:25:28
Also in: bpf, linux-mm, linux-rdma, lkml

On Thu, Jul 10, 2025 at 1:28 AM Byungchul Park [off-list ref] wrote:
quoted hunk ↗ jump to hunk
To eliminate the use of the page pool fields in struct page, the page
pool code should use netmem descriptor and APIs instead.

However, __netmem_get_pp() still accesses ->pp via struct page.  So
change it to use struct netmem_desc instead, since ->pp no longer will
be available in struct page.

Signed-off-by: Byungchul Park <byungchul@sk.com>
---
 include/net/netmem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netmem.h b/include/net/netmem.h
index 11e9de45efcb..283b4a997fbc 100644
--- a/include/net/netmem.h
+++ b/include/net/netmem.h
@@ -306,7 +306,7 @@ static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem)
  */
 static inline struct page_pool *__netmem_get_pp(netmem_ref netmem)
 {
-       return __netmem_to_page(netmem)->pp;
+       return __netmem_to_nmdesc(netmem)->pp;
 }
__netmem_to_nmdesc should introduced with this patch.

But also, I wonder why not modify all the callsites of
__netmem_to_page to the new __netmem_to_nmdesc and delete the
__nemem_to_page helper?


-- 
Thanks,
Mina
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help