Re: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-07-07 11:53:44
Also in:
linux-renesas-soc, lkml
There is a discrepancy between the value being passed by iproute2 and brctl. Iproute2 passes the value unaltered in seconds and brctl passes the value in seconds multiplied by 100. So far this is OK because brctl is deprecated. But the default value being passed when neither brctl is called nor the ageing parameter is added when the bridge is created is also multiplied by 100 resulting in 30000s being set as default ageing time instead of 300s. Is this a known issue?
You need to be careful of 100. It is probably the value of HZ you are using. This means it is probably in jiffies. It could be whoever added support to DSA was using HZ = 1000, and so assumed it has milliseconds, not jiffies, and the API is broken. If you have time, could you dig into this. Trace there where jiffies are used, seconds, and what conversions are preformed, for the default values, netlink API and sysfs API. Once we know where it goes wrong, we can figure out how to fix it. Andrew