Re: [PATCH net-next v12 04/14] dpll: zl3073x: Add support for devlink device info
flat view
From: Ivan Vecera <ivecera@redhat.com>
Date: 2025-07-02 11:53:08
Also in:
linux-devicetree, linux-doc, lkml
On 02. 07. 25 1:41 odp., Jiri Pirko wrote:
Wed, Jul 02, 2025 at 01:38:03PM +0200, ivecera@redhat.com wrote:quoted
On 02. 07. 25 12:25 odp., Jiri Pirko wrote:quoted
Sun, Jun 29, 2025 at 09:10:39PM +0200, ivecera@redhat.com wrote: [...]quoted
+ snprintf(buf, sizeof(buf), "%lu.%lu.%lu.%lu", + FIELD_GET(GENMASK(31, 24), cfg_ver), + FIELD_GET(GENMASK(23, 16), cfg_ver), + FIELD_GET(GENMASK(15, 8), cfg_ver), + FIELD_GET(GENMASK(7, 0), cfg_ver)); + + return devlink_info_version_running_put(req, "cfg.custom_ver", buf);Nit: It's redundant to put "ver" string into version name. Also, isn't it rather "custom_config" or "custom_cfg"?As per datasheet, this is configuration custom version.This is UAPI, we define it and we should make sure it make sense. Datasheet is sort of irrelevant.
OK, 'custom_cfg' make sense. Will update. I.