On Tue, 15 Jul 2025 13:27:51 +0300 Gal Pressman wrote:
quoted
IOCTL has two separate calls for this so there's no way to even try
to change both at once. I'll add "unlike IOCTL which has separate
calls" ?
So it's different because you can use netlink directly to change both,
but from userspace ethtool perspective there's no difference, right?
It's still two commands.
Yup! The existing CLI will likely stay as is.
Makes sense, thanks for the explanation.
quoted
quoted
Why not use mod?
Because it's a difference driver-facing op.
Why do we need to differentiate where the mod originated? We have a
single return value.
Right, but if we only modified the indirection table there's no need
to call the driver to update the hashing fields and vice versa.
To be clear this is just "an optimization", doesn't affect correctness
in any way.