Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec

From
Jakub Kicinski <kuba@kernel.org>
Date
2025-07-15 14:45:35
Reply to
Gal Pressman, 2025-07-15
On Tue, 15 Jul 2025 11:35:08 +0300 Gal Pressman wrote:
We kinda use input_xfrm as an enum, but in theory it's a bitmask, so
while this is OK today, I'm not sure this patch is future-proof.
Yeah, a little unclear at this stage if it's a bitmask or an enum since
we only have values 0 1 2 defined, and the defined values cannot be
composed. Adding an entry that'd compose would be painful if we go with
the string. OTOH I can't think of any composable transform and it's
extra effort to extract the entry form a one-element set each time.

I guess we should go with future-proofness when in doubt. 
I'll make it into flags in v3.
Thread (19 messages) 19 messages, 2 authors, last reply 2025-07-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help