Thread (11 messages) 11 messages, 3 authors, 2025-06-30

Re: [PATCH net v3 4/4] net: phy: bcm54811: Fix the PHY initialization

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2025-06-30 17:04:11
Also in: linux-devicetree, lkml

On 6/30/25 04:30, Kamil Horák - 2N wrote:
Reset the bit 12 in PHY's LRE Control register upon initialization.
According to the datasheet, this bit must be written to zero after
every device reset.

Signed-off-by: Kamil Horák - 2N <redacted>
---
[snip]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
index 15c35655f482..115a964f3006 100644
--- a/include/linux/brcmphy.h
+++ b/include/linux/brcmphy.h
@@ -137,6 +137,7 @@
  
  #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC			0x07
  #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN	0x0010
+#define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RSVD		0x0060
This hunk does not belong in this patch but the previous one. With that 
addressed:

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help