Thread (20 messages) 20 messages, 2 authors, 2025-07-01

Re: [PATCH 4/5] vsock/virtio: Rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put()

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2025-06-27 10:46:29
Also in: lkml, virtualization

On Wed, Jun 25, 2025 at 02:15:42PM +0100, Will Deacon wrote:
In preparation for using virtio_vsock_skb_rx_put() when populating SKBs
on the vsock TX path, rename virtio_vsock_skb_rx_put() to
virtio_vsock_skb_put().

No functional change.

Signed-off-by: Will Deacon <will@kernel.org>
---
drivers/vhost/vsock.c            | 2 +-
include/linux/virtio_vsock.h     | 2 +-
net/vmw_vsock/virtio_transport.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
LGMT!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
quoted hunk ↗ jump to hunk
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index cfa4e1bcf367..3799c0aeeec5 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -380,7 +380,7 @@ vhost_vsock_alloc_skb(struct vhost_virtqueue *vq,
		return NULL;
	}

-	virtio_vsock_skb_rx_put(skb);
+	virtio_vsock_skb_put(skb);

	if (skb_copy_datagram_from_iter(skb, 0, &iov_iter, payload_len)) {
		vq_err(vq, "Failed to copy %zu byte payload\n", payload_len);
diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
index 8f9fa1cab32a..d237ca0fc320 100644
--- a/include/linux/virtio_vsock.h
+++ b/include/linux/virtio_vsock.h
@@ -47,7 +47,7 @@ static inline void virtio_vsock_skb_clear_tap_delivered(struct sk_buff *skb)
	VIRTIO_VSOCK_SKB_CB(skb)->tap_delivered = false;
}

-static inline void virtio_vsock_skb_rx_put(struct sk_buff *skb)
+static inline void virtio_vsock_skb_put(struct sk_buff *skb)
{
	u32 len;
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index f0e48e6911fc..3319be2ee3aa 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -648,7 +648,7 @@ static void virtio_transport_rx_work(struct work_struct *work)
				continue;
			}

-			virtio_vsock_skb_rx_put(skb);
+			virtio_vsock_skb_put(skb);
			virtio_transport_deliver_tap_pkt(skb);
			virtio_transport_recv_pkt(&virtio_transport, skb);
		}
-- 
2.50.0.714.g196bf9f422-goog
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help