Thread (23 messages) 23 messages, 2 authors, 2025-06-30

Re: [net-next v13 04/11] net: mtip: The L2 switch driver for imx287

From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-06-24 13:37:19
Also in: imx, linux-arm-kernel, linux-devicetree, lkml

On 6/22/25 11:37 AM, Lukasz Majewski wrote:
+static void mtip_adjust_link(struct net_device *dev)
+{
+	struct mtip_ndev_priv *priv = netdev_priv(dev);
+	struct switch_enet_private *fep = priv->fep;
+	struct phy_device *phy_dev;
+	int status_change = 0, idx;
+	unsigned long flags;
+
+	spin_lock_irqsave(&fep->hw_lock, flags);
The above kind of lock look incorrect. In later patch you use
spin_lock_bh(), and the context here is never irq.

Should be spin_lock_bh()

/P
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help