Re: [PATCH net-next v2 2/3] net: phy: bcm5481x: Implement MII-Lite mode
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2025-06-23 15:58:35
Also in:
linux-devicetree, lkml
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2025-06-23 15:58:35
Also in:
linux-devicetree, lkml
On Mon, Jun 23, 2025 at 05:10:46PM +0200, Kamil Horák - 2N wrote:
+ priv->mii_lite_mode = of_property_read_bool(np, "mii-lite-mode");
Do we really want a property for this, or is it really a separate interface mode? Should we introduce PHY_INTERFACE_MODE_MII_LITE ?
+ if (!phy_interface_is_rgmii(phydev) ||
+ phydev->interface == PHY_INTERFACE_MODE_MII) {Same comment on this as in patch 1. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!