Re: [PATCH v5 01/13] dt-bindings: net: mediatek,net: update for mt7988
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-06-22 11:10:34
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-pm, lkml
On Fri, Jun 20, 2025 at 10:35:32AM +0200, Frank Wunderlich wrote:
From: Frank Wunderlich <redacted> Update binding for mt7988 which has 3 gmac and 2 reg items.
Why?
quoted hunk ↗ jump to hunk
MT7988 has 4 FE IRQs (currently only 2 are used) and the 4 IRQs for use with RSS/LRO later. Add interrupt-names to make them accessible by name. Signed-off-by: Frank Wunderlich <redacted> --- v5: - fix v4 logmessage and change description a bit describing how i get the irq count. - update binding for 8 irqs with different names (rx,tx => fe0..fe3) including the 2 reserved irqs which can be used later - change rx-ringX to pdmaX to be closer to hardware documentation v4: - increase max interrupts to 6 because of adding RSS/LRO interrupts (4) and dropping 2 reserved irqs (0+3) around rx+tx - dropped Robs RB due to this change - allow interrupt names - add interrupt-names without reserved IRQs on mt7988 this requires mtk driver patch: https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ v2: - change reg to list of items --- .../devicetree/bindings/net/mediatek,net.yaml | 30 ++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml index 9e02fd80af83..9465b40683ad 100644 --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml@@ -28,7 +28,10 @@ properties: - ralink,rt5350-eth reg: - maxItems: 1 + items: + - description: Register for accessing the MACs. + - description: SoC internal SRAM used for DMA operations.
SRAM like mmio-sram?
quoted hunk ↗ jump to hunk
+ minItems: 1 clocks: minItems: 2@@ -40,7 +43,11 @@ properties: interrupts: minItems: 1 - maxItems: 4 + maxItems: 8 + + interrupt-names: + minItems: 1 + maxItems: 8
So now all variants get unspecified names? You need to define it. Or just drop.
quoted hunk ↗ jump to hunk
power-domains: maxItems: 1@@ -348,7 +355,19 @@ allOf: then: properties: interrupts: - minItems: 4 + minItems: 2
Why? Didn't you say it has 4?
quoted hunk ↗ jump to hunk
+ + interrupt-names: + minItems: 2 + items: + - const: fe0 + - const: fe1 + - const: fe2 + - const: fe3 + - const: pdma0 + - const: pdma1 + - const: pdma2 + - const: pdma3 clocks: minItems: 24@@ -381,8 +400,11 @@ allOf: - const: xgp2 - const: xgp3 + reg: + minItems: 2
And all else? Why they got 2 reg and 8 interrupts now? All variants are now affected/changed. We have been here: you need to write specific bindings. https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127 https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml#L39 Best regards, Krzysztof