Re: [net-next PATCH v6 09/10] net: macb: Support external PCSs

Hi Sean,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/dt-bindings-net-Add-Xilinx-PCS/20250611-143544
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250610233642.3588414-1-sean.anderson%40linux.dev
patch subject: [net-next PATCH v6 09/10] net: macb: Support external PCSs
config: xtensa-randconfig-r062-20250613 (https://download.01.org/0day-ci/archive/20250613/202506132226.hNuGyG9l-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250613/202506132226.hNuGyG9l-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202506132226.hNuGyG9l-lkp@intel.com/ (local)

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/cadence/macb_main.c:24:
   include/linux/pcs.h: In function 'pcs_get_by_fwnode_compat':
   include/linux/pcs.h:201:16: error: implicit declaration of function '_pcs_get_tail' [-Werror=implicit-function-declaration]
     201 |         return _pcs_get_tail(dev, fwnode, NULL);
         |                ^~~~~~~~~~~~~

quoted

include/linux/pcs.h:201:16: warning: returning 'int' from a function with return type 'struct phylink_pcs *' makes pointer from integer without a cast [-Wint-conversion]

     201 |         return _pcs_get_tail(dev, fwnode, NULL);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +201 include/linux/pcs.h

56201bc1ac71fc Sean Anderson 2025-06-10  187  
56201bc1ac71fc Sean Anderson 2025-06-10  188  #ifdef CONFIG_OF_DYNAMIC
56201bc1ac71fc Sean Anderson 2025-06-10  189  struct phylink_pcs *
56201bc1ac71fc Sean Anderson 2025-06-10  190  pcs_get_by_fwnode_compat(struct device *dev, struct fwnode_handle *fwnode,
56201bc1ac71fc Sean Anderson 2025-06-10  191  			 int (*fixup)(struct of_changeset *ocs,
56201bc1ac71fc Sean Anderson 2025-06-10  192  				      struct device_node *np, void *data),
56201bc1ac71fc Sean Anderson 2025-06-10  193  			 void *data);
56201bc1ac71fc Sean Anderson 2025-06-10  194  #else
56201bc1ac71fc Sean Anderson 2025-06-10  195  static inline struct phylink_pcs *
56201bc1ac71fc Sean Anderson 2025-06-10  196  pcs_get_by_fwnode_compat(struct device *dev, struct fwnode_handle *fwnode,
56201bc1ac71fc Sean Anderson 2025-06-10  197  			 int (*fixup)(struct of_changeset *ocs,
56201bc1ac71fc Sean Anderson 2025-06-10  198  				      struct device_node *np, void *data),
56201bc1ac71fc Sean Anderson 2025-06-10  199  			 void *data)
56201bc1ac71fc Sean Anderson 2025-06-10  200  {
56201bc1ac71fc Sean Anderson 2025-06-10 @201  	return _pcs_get_tail(dev, fwnode, NULL);
56201bc1ac71fc Sean Anderson 2025-06-10  202  }
56201bc1ac71fc Sean Anderson 2025-06-10  203  #endif
56201bc1ac71fc Sean Anderson 2025-06-10  204  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki