Re: [PATCH 2/2] docs: net: clarify sysctl value constraints
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2025-06-12 17:20:03
Also in:
linux-doc, linux-kernel-mentees, lkml
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2025-06-12 17:20:03
Also in:
linux-doc, linux-kernel-mentees, lkml
On 6/12/2025 9:29 AM, Abdelrahman Fekry wrote:
So, i also noticed that some of the parameters represented as boolean have no value constrain checks and accept integer values due to u8 implementation, so i wrote a note for every boolean parameter that have no constrain checks in code. and fixed a typo in fmwark instead of fwmark. Added notes for 19 confirmed parameters, Verified by code inspection and runtime testing. Signed-off-by: Abdelrahman Fekry <redacted> --- Documentation/networking/ip-sysctl.rst | 50 +++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 5 deletions(-)diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst index f7ff8c53f412..99e786915204 100644 --- a/Documentation/networking/ip-sysctl.rst +++ b/Documentation/networking/ip-sysctl.rst@@ -68,6 +68,8 @@ ip_forward_use_pmtu - BOOLEAN - 0 - disabled - 1 - enabled + + note: Accepts integer values (0-255) but only 0/1 have defined behaviour.
Hm. In many cases any non-zero value might be interpreted as "enabled" I suppose that is simply "undefined behavior"?