[PATCH] net: ipconfig: replace strncpy with strscpy
From: Pranav Tyagi <hidden>
Date: 2025-06-07 15:28:44
Also in:
linux-kernel-mentees, lkml
Subsystem:
networking [general], networking [ipv4/ipv6], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds
Replace the deprecated strncpy() with strscpy() as the destination buffer is NUL-terminated and does not require any trailing NUL-padding. Also increase the length to 252 as NUL-termination is guaranteed. Signed-off-by: Pranav Tyagi <redacted> --- net/ipv4/ipconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index c56b6fe6f0d7..eb9b32214e60 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c@@ -1690,7 +1690,7 @@ static int __init ic_proto_name(char *name) *v = 0; if (kstrtou8(client_id, 0, dhcp_client_identifier)) pr_debug("DHCP: Invalid client identifier type\n"); - strncpy(dhcp_client_identifier + 1, v + 1, 251); + strscpy(dhcp_client_identifier + 1, v + 1, 252); *v = ','; } return 1;
--
2.49.0